Fixes annoying qr popup on parsing LNURL withdraw receive in wallet #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i cannot really tell what the issue is, can you provide a screenshot or something what the problem is? |
dni
approved these changes
Feb 5, 2024
motorina0
reviewed
Feb 5, 2024
| </q-card> | ||
| <q-card v-else class="q-pa-lg q-pt-xl lnbits__dialog-card"> | ||
| <q-card | ||
| v-else-if="receive.paymentReq && receive.lnurl == null" |
There was a problem hiding this comment.
the corresponding v-if is:
<q-card
v-if="!receive.paymentReq"so receive.paymentReq is not required in this condition
There was a problem hiding this comment.
Thats for the parse card in the dialogue
motorina0
reviewed
Feb 5, 2024
| </q-card> | ||
| <q-card v-else class="q-pa-lg q-pt-xl lnbits__dialog-card"> | ||
| <q-card | ||
| v-else-if="receive.paymentReq && receive.lnurl == null" |
There was a problem hiding this comment.
Suggested change
| v-else-if="receive.paymentReq && receive.lnurl == null" | |
| v-else-if="receive.lnurl == null" |
There was a problem hiding this comment.
what if this condition is false: receive.lnurl == null (ie. receive.lnurl != null)?
There was a problem hiding this comment.
The invoice QR code card in the dialogue should only fire creating an invoice, not when an invoice is parsed out of an lnurl-withdraw.
Making false would mean the opposite, and would e even worse than before.
motorina0
approved these changes
Feb 5, 2024
talvasconcelos
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.