Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add monitor admin endpoint for listeners #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat: add monitor admin endpoint for listeners #2242

merged 1 commit into from
Feb 9, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Feb 7, 2024

screenshot-1707292057

this can be useful when debugging invoice listeners. in the future there coud be some monitor dashboard on the admin ui.

@codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f07b407) 59.24% compared to head (c36e7b4) 59.25%.

Files Patch % Lines
lnbits/core/views/admin_api.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2242      +/-   ##
==========================================
+ Coverage   59.24%   59.25%   +0.01%     
==========================================
  Files          60       60              
  Lines        8992     8997       +5     
==========================================
+ Hits         5327     5331       +4     
- Misses       3665     3666       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni marked this pull request as ready for review February 7, 2024 07:52
@arcbtc
Copy link
Member

arcbtc commented Feb 7, 2024

Wow, cool

@arcbtc arcbtc self-requested a review February 7, 2024 12:03
@dni @arcbtc
feat: add monitor admin endpoint for listeners
c36e7b4 
this can be useful when debugging invoice listeners. in the future there coud be some monitor dashboard on the admin ui.
@arcbtc arcbtc force-pushed the feat-show-listeners branch from b92f7f5 to c36e7b4 Compare February 7, 2024 21:03
@dni dni added this to the 0.12.1 milestone Feb 9, 2024
@dni dni merged commit 6f135c0 into dev Feb 9, 2024
@dni dni deleted the feat-show-listeners branch February 9, 2024 07:08
@dni dni modified the milestones: 0.12.2, 0.12.1 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@motorina0 motorina0 motorina0 approved these changes

@arcbtc arcbtc arcbtc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.1

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @arcbtc @motorina0