feat: unique invoice listeners for extensions #2250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2250 +/- ##
==========================================
- Coverage 59.31% 59.29% -0.02%
==========================================
Files 60 60
Lines 9041 9044 +3
==========================================
Hits 5363 5363
- Misses 3678 3681 +3 ☔ View full report in Codecov by Sentry. |
a457eb8 to
cf49864
Compare
arcbtc
approved these changes
Feb 9, 2024
cf49864 to
c0a68b0
Compare
This was referenced Feb 14, 2024
c0be88a to
66bb924
Compare
changes the `register_invoice_listener` to use a non unique key so you its not possible to have a listeners running twice and throw a warning when trying to.
66bb924 to
0329616
Compare
motorina0
approved these changes
Feb 20, 2024
talvasconcelos
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the
register_invoice_listenerto use a non unique key so you its not possible to have a listeners running twice and throw a warning when trying to.we should discourage use of
get_current_extension_nameits not needed, easy enough for the extension dev to pass the extension name or whatever he wants his listener to be named.@talvasconcelos some extension still don't use a name, but they should! can you check that? also they should not use
get_current_extension_name()anymore