Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Feb 13, 2024

Summary

PR depends on #2263
Closes #2212

Add support for Keycloak SSO. This PR serves as an example for other SSO implementations.

Screen Recording:

keycloak_login.mov

Screenshots:
image

Tests

  • see video
  • please DM for Keycloak secrets

@motorina0 motorina0 changed the title Keycloak SSO Add Keycloak SSO Feb 13, 2024
@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8d295a) 57.83% compared to head (64f962d) 59.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2272      +/-   ##
==========================================
+ Coverage   57.83%   59.29%   +1.46%     
==========================================
  Files          60       60              
  Lines        9036     9041       +5     
==========================================
+ Hits         5226     5361     +135     
+ Misses       3810     3680     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 requested review from arcbtc, dni and prusnak February 13, 2024 10:50
@motorina0 motorina0 marked this pull request as ready for review February 13, 2024 10:50
@motorina0 motorina0 added this to the 0.12.2 milestone Feb 13, 2024
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Base automatically changed from generalize_sso to dev February 14, 2024 06:57
@dni dni changed the base branch from dev to main February 14, 2024 06:58
@dni dni changed the base branch from main to dev February 14, 2024 07:01
@dni dni merged commit 5264677 into dev Feb 14, 2024
@dni dni deleted the keycloak_sso branch February 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Allow custom OIDC Providers for SSO

4 participants