Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@blackcoffeexbt
Copy link
Collaborator

No description provided.

@prusnak prusnak added this to the 0.12.2 milestone Feb 13, 2024
@dni
Copy link
Member

dni commented Feb 14, 2024

can you share a screenshot on how it looks, the call to init the markdown is still missing right?

Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dni

This comment was marked as resolved.

@dni dni modified the milestones: 0.12.2, 0.12.3 Feb 15, 2024
@motorina0
Copy link
Collaborator

can you share a screenshot on how it looks, the call to init the markdown is still missing right?

image

@motorina0
Copy link
Collaborator

ci failing

fixed

@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b7826) 59.28% compared to head (b752024) 59.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2273   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files          60       60           
  Lines        9029     9029           
=======================================
  Hits         5353     5353           
  Misses       3676     3676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 modified the milestones: 0.12.3, 0.12.2 Feb 20, 2024
@motorina0 motorina0 merged commit fe12ecc into lnbits:dev Feb 20, 2024
@DoktorShift
Copy link
Collaborator

DoktorShift commented Feb 25, 2024

i had regarding to that wonderfull pr vom BC the thought to force push the new user to "my account" section. Do not display the "I understand" button. So new user have to go to "my Account" otherwise the add will not disapear.

It would be a tradeoff security vs. comfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants