-
-
Notifications
You must be signed in to change notification settings - Fork 371
Updated new wallet warning modal text to clarify importance of backing up login creds #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
can you share a screenshot on how it looks, the call to init the markdown is still missing right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2273 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 60 60
Lines 9029 9029
=======================================
Hits 5353 5353
Misses 3676 3676 ☔ View full report in Codecov by Sentry. |
|
i had regarding to that wonderfull pr vom BC the thought to force push the new user to "my account" section. Do not display the "I understand" button. So new user have to go to "my Account" otherwise the add will not disapear. It would be a tradeoff security vs. comfort |
No description provided.