Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Jmeter take 3 #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Mar 8, 2024
Merged

Jmeter take 3 #2284

merged 37 commits into from
Mar 8, 2024

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Feb 20, 2024 •
edited
Loading

Summary

Add JMeter CI job and tests for some extensions.

In the future the tests that cover extensions should be moved to the lnbits-extensions repo and triggered when a PR is open for the extension or when dev branch of lnbits is updated.

Tests

The added tests cover:

Server

  • init super user
  • topup wallet
  • init regular user

TPOS

  • enable extension
  • create LNURLp payment links
  • pay to LNURLp
  • create LNURLw withdraw links
  • withdraw from LNURLw

@codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.54%. Comparing base (3e341a3) to head (17b7a05).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2284   +/-   ##
=======================================
  Coverage   58.54%   58.54%           
=======================================
  Files          61       61           
  Lines        9185     9185           
=======================================
  Hits         5377     5377           
  Misses       3808     3808

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review March 6, 2024 11:04
@motorina0 motorina0 changed the title [WIP] Jmeter take 3 Jmeter take 3 Mar 6, 2024
@arcbtc
Copy link
Member

arcbtc commented Mar 7, 2024

lgtm, how do we test the test?

@motorina0
Copy link
Collaborator Author

lgtm, how do we test the test?

Break something in core or in the tested extensions.
LNURLp example:

  • do not call webhook when payment made
  • test should fail

@arcbtc arcbtc requested a review from blackcoffeexbt March 8, 2024 14:32
@motorina0 motorina0 merged commit a1ea04a into dev Mar 8, 2024
@motorina0 motorina0 deleted the jmter_take_3 branch March 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talvasconcelos talvasconcelos talvasconcelos approved these changes

@arcbtc arcbtc arcbtc approved these changes

@dni dni Awaiting requested review from dni

@blackcoffeexbt blackcoffeexbt Awaiting requested review from blackcoffeexbt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@motorina0 @arcbtc @talvasconcelos