Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dni
Copy link
Member

@dni dni commented Feb 20, 2024

database functions should be in crud

database functions should be in crud
@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.26%. Comparing base (fe12ecc) to head (bbb193d).
⚠️ Report is 663 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/core/tasks.py 0.00% 3 Missing ⚠️
lnbits/core/crud.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2286      +/-   ##
==========================================
- Coverage   59.28%   59.26%   -0.03%     
==========================================
  Files          60       60              
  Lines        9029     9028       -1     
==========================================
- Hits         5353     5350       -3     
- Misses       3676     3678       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni added this to the 0.12.3 milestone Feb 21, 2024
Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spotting it!

@dni dni requested a review from prusnak February 21, 2024 14:08
@prusnak prusnak merged commit 54c6faa into dev Feb 21, 2024
@prusnak prusnak deleted the refactor-webhooksent branch February 21, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants