Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: deprecate get_current_extension_name #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: deprecate get_current_extension_name #2280

merged 1 commit into from
Feb 16, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Feb 15, 2024 

DEPRECATED: Use the repo name instead, will be removed in the future
before: `register_invoice_listener(invoice_queue, get_current_extension_name())`
after: `register_invoice_listener(invoice_queue, "my-extension")`

@codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5264677) 59.31% compared to head (79244a1) 59.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2280      +/-   ##
==========================================
- Coverage   59.31%   59.29%   -0.03%     
==========================================
  Files          60       60              
  Lines        9041     9041              
==========================================
- Hits         5363     5361       -2     
- Misses       3678     3680       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

motorina0
motorina0 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs only, approved

@dni dni added this to the 0.12.2 milestone Feb 15, 2024
@motorina0 motorina0 added the code health Make the code more beautiful label Feb 15, 2024
prusnak
prusnak approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@motorina0 motorina0 merged commit dc7a655 into dev Feb 16, 2024
@motorina0 motorina0 deleted the chore-deprecate-extensioname branch February 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@motorina0 motorina0 motorina0 approved these changes

Assignees

No one assigned

Labels

code health Make the code more beautiful

Projects

None yet

Milestone

0.12.2

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @prusnak @motorina0