feat: make route hints configurable for lndrest #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2304 +/- ##
==========================================
+ Coverage 58.47% 58.49% +0.01%
==========================================
Files 61 61
Lines 9265 9266 +1
==========================================
+ Hits 5418 5420 +2
+ Misses 3847 3846 -1 ☔ View full report in Codecov by Sentry. |
you mean the dynamic component does not support bool/checkbox? |
yes |
motorina0
approved these changes
Mar 22, 2024
boolean if route hints for private channels will be included from `LndRest` inside bolt11 invoice. note: fundingsources do not have more than text inputs yet when rendered
arcbtc
approved these changes
Mar 22, 2024
talvasconcelos
approved these changes
Mar 22, 2024
talvasconcelos
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolean if route hints for private channels will be included from
LndRestinside bolt11 invoice.note: fundingsources do not have more than text inputs yet when rendered