Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Feb 29, 2024

An warning message is shown in the logs when users update the settings:

| WARNING | lnbits.core.services:update_cached_settings:716 | Failed overriding setting: is_super_user, value: True

This PR fixes the warning message.

@codecov
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.55%. Comparing base (884a1b9) to head (2799be2).

Files Patch % Lines
lnbits/core/services.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2306   +/-   ##
=======================================
  Coverage   58.54%   58.55%           
=======================================
  Files          61       61           
  Lines        9184     9187    +3     
=======================================
+ Hits         5377     5379    +2     
- Misses       3807     3808    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review March 7, 2024 10:35
@dni dni added this to the 0.12.3 milestone Mar 8, 2024
@arcbtc arcbtc merged commit 5b43989 into dev Mar 12, 2024
@arcbtc arcbtc deleted the fix_settings_update branch March 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants