Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix login logout on safari #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix login logout on safari #2309

merged 2 commits into from
Mar 7, 2024

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Mar 5, 2024 •
edited
Loading

Fixes:

  • the account icon is not visible on Safari & Firefox
  • the active wallet cookie not removed after logout

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.54%. Comparing base (884a1b9) to head (f1fe89a).

Files Patch % Lines
lnbits/core/views/auth_api.py 0.00% 3 Missing ⚠️
lnbits/app.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2309      +/-   ##
==========================================
- Coverage   58.54%   58.54%   -0.01%     
==========================================
  Files          61       61              
  Lines        9184     9185       +1     
==========================================
  Hits         5377     5377              
- Misses       3807     3808       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review March 5, 2024 11:25
@motorina0 motorina0 requested review from arcbtc, dni and jackstar12 March 5, 2024 11:25
@newtonick
Copy link

I tried this PR in Safari version 17.3.1 on macOS 14.3.1 and I was still not able to logout successfully.

@newtonick
Copy link

I tried this PR in Safari version 17.3.1 on macOS 14.3.1 and I was still not able to logout successfully.

I take it back, after I restarted Safari and tested again it works. Looking forward to this getting merged and released.

@motorina0 motorina0 requested a review from talvasconcelos March 6, 2024 08:30
@motorina0 motorina0 added this to the 0.12.3 milestone Mar 6, 2024
@arcbtc arcbtc merged commit cb5c9b0 into dev Mar 7, 2024
@arcbtc arcbtc deleted the fix_login_logout_on_safari branch March 7, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talvasconcelos talvasconcelos talvasconcelos approved these changes

@arcbtc arcbtc arcbtc approved these changes

@dni dni Awaiting requested review from dni

@jackstar12 jackstar12 Awaiting requested review from jackstar12

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.3

Development

Successfully merging this pull request may close these issues.

4 participants

@motorina0 @newtonick @talvasconcelos @arcbtc