Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Refactor payment status mapping #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 64 commits into from
Closed

[WIP] Refactor payment status mapping #2323

wants to merge 64 commits into from

Conversation

@motorina0
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.89610% with 142 lines in your changes are missing coverage. Please review.

Project coverage is 59.27%. Comparing base (d44339b) to head (4f02501).
Report is 17 commits behind head on dev.

❗ Current head 4f02501 differs from pull request most recent head a771813. Consider uploading reports for the commit a771813 to get more accurate results

Files Patch % Lines
lnbits/wallets/spark.py 8.33% 22 Missing ⚠️
lnbits/wallets/corelightning.py 43.47% 13 Missing ⚠️
lnbits/wallets/cliche.py 14.28% 12 Missing ⚠️
lnbits/wallets/lntips.py 15.38% 11 Missing ⚠️
lnbits/wallets/opennode.py 16.66% 10 Missing ⚠️
lnbits/wallets/lnpay.py 18.18% 9 Missing ⚠️
lnbits/wallets/zbd.py 18.18% 9 Missing ⚠️
lnbits/wallets/lndgrpc.py 65.21% 8 Missing ⚠️
lnbits/wallets/lndrest.py 61.90% 8 Missing ⚠️
lnbits/wallets/alby.py 22.22% 7 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2323      +/-   ##
==========================================
+ Coverage   58.57%   59.27%   +0.70%     
==========================================
  Files          61       61              
  Lines        9218     9317      +99     
==========================================
+ Hits         5399     5523     +124     
+ Misses       3819     3794      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 changed the base branch from dev to refactor_payment_status_names March 13, 2024 13:28
@motorina0 motorina0 mentioned this pull request Mar 13, 2024
Merged
@motorina0
Copy link
Collaborator Author

Note:

I find PaymentStatusPending, PaymentStatusFailed and PaymentStatusSuccess better than PaymentPendingStatus, PaymentFailedStatus and PaymentSuccessStatus. Any thoughts?

Base automatically changed from refactor_payment_status_names to dev March 13, 2024 15:17
@motorina0 motorina0 force-pushed the refactor_payment_status_mapping branch from 554c80d to 38a7fed Compare March 14, 2024 12:48
dni
dni reviewed Mar 21, 2024
View reviewed changes
tests/wallets/test_lndrest.py
+ "nwgqqqqqqqqqqqqqqpsqyg9qxpqysgqy"
+ "lngsyg960lltngzy90e8n22v4j2hvjs4"
+ "l4ttuy79qqefjv8q87q9ft7uhwdjakvn"
+ "sgk44qyhalv6ust54x98whl3q635hkwgsyw8xgqjl7jwu",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo actually don't need to +

motorina0 added 15 commits March 21, 2024 12:13
@dni dni added this to the 0.12.4 milestone Mar 22, 2024
@dni dni modified the milestones: 0.12.5, 0.12.6 Apr 11, 2024
@motorina0
Copy link
Collaborator Author

Dead meat!
PR will be re-created on top of the latest changes.
Closing.

@motorina0 motorina0 closed this Jul 31, 2024
@dni dni deleted the refactor_payment_status_mapping branch August 1, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak left review comments

@dni dni dni left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.6

Development

Successfully merging this pull request may close these issues.

3 participants

@motorina0 @prusnak @dni