Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: reduce initial requests on wallet page #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat: reduce initial requests on wallet page #2335

merged 3 commits into from
Mar 22, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Mar 21, 2024

  • refactor allowed_currencies into function to use in generic and api.
  • remove currencies request in frontend move it to generic
  • dont request balance on first payments fetch

@dni dni requested review from jackstar12 and motorina0 March 21, 2024 08:45
@dni dni changed the title feat: reduce initial request on wallet page feat: reduce initial requests on wallet page Mar 21, 2024
@dni dni force-pushed the duplicate-wallet-req branch from b395a5f to fec8790 Compare March 21, 2024 09:17
@dni dni force-pushed the optimize-wallet branch from d85f6e5 to ad7ae4b Compare March 21, 2024 09:17
@dni dni added this to the 0.12.3 milestone Mar 21, 2024
Base automatically changed from duplicate-wallet-req to dev March 21, 2024 12:13
@dni dni force-pushed the optimize-wallet branch 2 times, most recently from 7e381f6 to d8ce6f7 Compare March 21, 2024 12:34
@dni dni requested review from arcbtc and talvasconcelos March 21, 2024 12:34
@codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.49%. Comparing base (5b022e2) to head (f8d855d).

Files Patch % Lines
lnbits/core/views/api.py 50.00% 1 Missing ⚠️
lnbits/utils/exchange_rates.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2335      +/-   ##
==========================================
- Coverage   58.49%   58.49%   -0.01%     
==========================================
  Files          61       61              
  Lines        9266     9268       +2     
==========================================
+ Hits         5420     5421       +1     
- Misses       3846     3847       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dni added 3 commits March 22, 2024 12:49
@dni
feat: reduce initial request on wallet page
aa5578c 
- refactor allowed_currencies into function to use in generic and api.
- remove currencies request in frontend move it to generic
- dont request balance on first payments fetch

black
@dni
fixup!
562b6e9
@dni
fixup!
f8d855d
@dni dni force-pushed the optimize-wallet branch from d8ce6f7 to f8d855d Compare March 22, 2024 11:53
motorina0
motorina0 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dni dni merged commit 299228b into dev Mar 22, 2024
@dni dni deleted the optimize-wallet branch March 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@motorina0 motorina0 motorina0 approved these changes

@talvasconcelos talvasconcelos talvasconcelos approved these changes

@jackstar12 jackstar12 Awaiting requested review from jackstar12

@arcbtc arcbtc Awaiting requested review from arcbtc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.3

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @motorina0 @talvasconcelos