feat: complete use of LNBITS_EXTENSIONS_DEACTIVATE_ALL
#2341
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2341 +/- ##
==========================================
+ Coverage 57.44% 58.35% +0.90%
==========================================
Files 61 61
Lines 9334 9336 +2
==========================================
+ Hits 5362 5448 +86
+ Misses 3972 3888 -84 ☔ View full report in Codecov by Sentry. |
|
Does this affect paid extensions ? Is the payment to be redone if reactivated ? |
|
disabled all extension and it lets you run lnbits without them, maybe if you don't need any. |
- add to admin ui - move to `ExtensionsSettings` - hide left navbar when disabled - do not register extension routes on startup - do not check for installed extensions on startup
| ext.nofiy_upgrade() | ||
|
|
||
|
|
||
| def register_routes(app: FastAPI) -> None: |
There was a problem hiding this comment.
- why remove this method?
- it is better to have many small methods with well defined names rather than bigger methods which are hard to follow
There was a problem hiding this comment.
in this case i absolutely disagree, register_routes mixing up registering extension routes with initializing the core routers.
helper function for helper functions are hard to follow because you jump around everywhere in the code and makes it so you cant follow it!
it is a balance and it this case it went 1 abstraction too far
LNBITS_EXTENSIONS_DEACTIVE_ALLLNBITS_EXTENSIONS_DEACTIVATE_ALL
- add to admin ui - move to `ExtensionsSettings` - hide left navbar when disabled - do not register extension routes on startup - do not check for installed extensions on startup - reafctor into register_all_ext_routes
ExtensionsSettings