Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: adhere to ruff's "N" rules #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2024
Merged

chore: adhere to ruff's "N" rules #2377

merged 6 commits into from
Apr 15, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Apr 1, 2024 •
edited
Loading

bunch of more consistent variable naming. inspired by this issue. #2308
WARNING this breaks some imports in extensions, UPDATE them to fix!

jmeter tests temporarly disabled #2410

@dni dni requested review from motorina0 and prusnak April 1, 2024 16:23
@dni dni force-pushed the ruff-n branch 4 times, most recently from 4734533 to 47bdc13 Compare April 1, 2024 16:32
@dni dni added the code health Make the code more beautiful label Apr 1, 2024
@dni dni added this to the 0.12.5 milestone Apr 1, 2024
@codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.55140% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 59.97%. Comparing base (055426a) to head (7e0bf43).

Files Patch % Lines
lnbits/core/services.py 53.57% 13 Missing ⚠️
lnbits/core/views/auth_api.py 0.00% 7 Missing ⚠️
lnbits/core/views/generic.py 14.28% 6 Missing ⚠️
lnbits/app.py 75.00% 3 Missing ⚠️
lnbits/core/tasks.py 60.00% 2 Missing ⚠️
lnbits/core/views/websocket_api.py 50.00% 2 Missing ⚠️
lnbits/wallets/corelightning.py 0.00% 2 Missing ⚠️
lnbits/core/views/payment_api.py 87.50% 1 Missing ⚠️
lnbits/wallets/corelightningrest.py 0.00% 1 Missing ⚠️
lnbits/wallets/opennode.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2377      +/-   ##
==========================================
+ Coverage   59.96%   59.97%   +0.01%     
==========================================
  Files          65       65              
  Lines        9434     9434              
==========================================
+ Hits         5657     5658       +1     
+ Misses       3777     3776       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dni added a commit to lnbits/bleskomat that referenced this pull request Apr 2, 2024
@dni
chore: renaming of PaymentFailure
2a974f7 
lnbits/lnbits#2377
dni added a commit to lnbits/tpos that referenced this pull request Apr 2, 2024
@dni
chore: rename websocketUpdater
07d1872 
lnbits/lnbits#2377
@dni dni mentioned this pull request Apr 2, 2024
Merged
dni added a commit to lnbits/copilot that referenced this pull request Apr 2, 2024
@dni
chore: rename websocketUpdater
c323e3c 
lnbits/lnbits#2377
@dni dni mentioned this pull request Apr 2, 2024
Merged
dni added a commit to lnbits/lnurldevice that referenced this pull request Apr 2, 2024
@dni
chore: rename websocketUpdater
54bd21b 
lnbits/lnbits#2377
@dni dni mentioned this pull request Apr 2, 2024
Merged
dni added a commit to lnbits/nostrrelay that referenced this pull request Apr 2, 2024
@dni
chore: rename websocketUpdater
62fe506 
lnbits/lnbits#2377
@dni dni mentioned this pull request Apr 2, 2024
Merged
dni added a commit to lnbits/nostrmarket that referenced this pull request Apr 2, 2024
@dni
chore: rename websocketUpdater
9348e12 
lnbits/lnbits#2377
@dni dni mentioned this pull request Apr 2, 2024
Merged
@dni
Copy link
Member Author

dni commented Apr 2, 2024

6 extensions were incompatible, pr's are open with min_version 0.12.5

@prusnak prusnak mentioned this pull request Apr 5, 2024
Closed
@motorina0
Copy link
Collaborator

6 extensions were incompatible, pr's are open with min_version 0.12.5

That is why the JMeter tests fail?
Can you please add links to PRs here.

@motorina0
Copy link
Collaborator

motorina0 commented Apr 5, 2024 •
edited
Loading

JMeter test fail reasons:

Could not load extension `tpos`: cannot import name 'websocketUpdater' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)
Could not load extension `copilot`: cannot import name 'websocketUpdater' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)
Could not load extension `nostrrelay`: cannot import name 'websocketUpdater' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)
Could not load extension `lnurldevice`: cannot import name 'websocketUpdater' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)
Could not load extension `nostrmarket`: cannot import name 'websocketUpdater' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)
Could not load extension `bleskomat`: cannot import name 'PaymentFailure' from 'lnbits.core.services' ("lnbits/lnbits/core/services.py)

motorina0
motorina0 reviewed Apr 5, 2024
View reviewed changes
@dni dni modified the milestones: 0.12.5, 0.12.6 Apr 11, 2024
dni added a commit to lnbits/copilot that referenced this pull request Apr 12, 2024
@dni
chore: rename websocketUpdater (#16)
ddcf6f9 
* chore: rename `websocketUpdater`
lnbits/lnbits#2377
dni added a commit to lnbits/tpos that referenced this pull request Apr 12, 2024
@dni
chore: rename websocketUpdater (#78)
3028bda 
* chore: rename `websocketUpdater`
lnbits/lnbits#2377
dni added a commit to lnbits/lnurldevice that referenced this pull request Apr 12, 2024
@dni
chore: rename websocketUpdater (#36)
afd0871 
* chore: rename `websocketUpdater`
lnbits/lnbits#2377
dni added a commit to lnbits/nostrrelay that referenced this pull request Apr 12, 2024
@dni
chore: rename websocketUpdater (#21)
349bfa4 
* chore: rename `websocketUpdater`
lnbits/lnbits#2377
dni added a commit to lnbits/nostrmarket that referenced this pull request Apr 12, 2024
@dni
chore: rename websocketUpdater (#99)
49b4ae7 
* chore: rename `websocketUpdater`
lnbits/lnbits#2377
dni added a commit that referenced this pull request Apr 12, 2024
@dni
chore: prepare version update to 0.12.6
1ca4f97 
needed in preparation of #2377
@dni dni mentioned this pull request Apr 12, 2024
Merged
dni added a commit that referenced this pull request Apr 12, 2024
@dni
chore: prepare version update to 0.12.6 (#2407)
055426a 
needed in preparation of #2377
@dni
Copy link
Member Author

dni commented Apr 12, 2024 •
edited
Loading

#2409

after this pr os merge you need to update extensions listed in the above issue

@dni dni requested a review from talvasconcelos April 12, 2024 15:41
dni and others added 2 commits April 12, 2024 17:48
@dni
chore: adhere to ruff's "N" rules
16ddc31 
bunch of more consistent variable naming. inspired by this issue.
#2308
@prusnak @dni
fixup! chore: adhere to ruff's "N" rules
2c3691e
prusnak
prusnak requested changes Apr 13, 2024
View reviewed changes
@dni dni requested a review from prusnak April 15, 2024 05:30
@motorina0 motorina0 requested a review from arcbtc April 15, 2024 06:11
@dni dni merged commit 6d5ad9e into dev Apr 15, 2024
@dni dni deleted the ruff-n branch April 15, 2024 07:02
This was referenced Apr 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@motorina0 motorina0 motorina0 approved these changes

@talvasconcelos talvasconcelos Awaiting requested review from talvasconcelos

@arcbtc arcbtc Awaiting requested review from arcbtc

Assignees

No one assigned

Labels

code health Make the code more beautiful

Projects

None yet

Milestone

0.12.6

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @motorina0 @prusnak