chore: adhere to ruff's UP
#2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2378 +/- ##
=======================================
Coverage 59.97% 59.97%
=======================================
Files 65 65
Lines 9434 9434
=======================================
Hits 5658 5658
Misses 3776 3776 ☔ View full report in Codecov by Sentry. |
prusnak
requested changes
Apr 2, 2024
prusnak
approved these changes
Apr 3, 2024
basically use `list` and `type` instead of `List` and `Type` this is save to use for python3.9 and has been deprecated. also has some performance drawbacks. read more here: https://docs.astral.sh/ruff/rules/non-pep585-annotation/
motorina0
reviewed
Apr 15, 2024
| return | ||
|
|
||
| top_path, *rest = [p for p in full_path.split("/") if p] | ||
| top_path, *rest = (p for p in full_path.split("/") if p) |
There was a problem hiding this comment.
Why is a tuple preferred to a list?
There was a problem hiding this comment.
tuple is immutable and it is more obvious it is not to be changed (appended to) earlier
motorina0
approved these changes
Apr 15, 2024
prusnak
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically use
listandtypeinstead ofListandTypethis is save to use for python3.9 and has been deprecated. also has some performance drawbacks.
read more here: https://docs.astral.sh/ruff/rules/non-pep585-annotation/