Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: adhere to ruff's C #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

chore: adhere to ruff's C #2379

merged 2 commits into from
Apr 3, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Apr 1, 2024

note: max-complexity should be decreased to 10 in another PR.

@dni dni added the code health Make the code more beautiful label Apr 1, 2024
@dni dni added this to the 0.12.5 milestone Apr 1, 2024
@dni dni requested review from motorina0 and prusnak April 1, 2024 17:37
@codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.50%. Comparing base (c67fcf0) to head (61c62f5).

Files Patch % Lines
lnbits/core/views/extension_api.py 0.00% 1 Missing ⚠️
lnbits/core/views/generic.py 66.66% 1 Missing ⚠️
lnbits/core/views/payment_api.py 0.00% 1 Missing ⚠️
lnbits/middleware.py 0.00% 1 Missing ⚠️
lnbits/server.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2379   +/-   ##
=======================================
  Coverage   58.50%   58.50%           
=======================================
  Files          65       65           
  Lines        9379     9382    +3     
=======================================
+ Hits         5487     5489    +2     
- Misses       3892     3893    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

motorina0
motorina0 reviewed Apr 2, 2024
View reviewed changes
lnbits/nodes/lndrest.py
point: Optional[ChannelPoint] = None,
force: bool = False,
):
if short_id:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did ruff suggested this? how can it know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, that was a pyright, it was an unused local variable

prusnak
prusnak reviewed Apr 2, 2024
View reviewed changes
@prusnak
Copy link
Collaborator

prusnak commented Apr 2, 2024

@dni can you have a look at this CI failure? Is it related to the PR? https://github.com/lnbits/lnbits/actions/runs/8525288852/job/23351920497?pr=2379

@dni
Copy link
Member Author

dni commented Apr 3, 2024

@dni can you have a look at this CI failure? Is it related to the PR? https://github.com/lnbits/lnbits/actions/runs/8525288852/job/23351920497?pr=2379

wow, yes, that test saved us :). 61c62f5

@prusnak prusnak merged commit e0b7d2f into dev Apr 3, 2024
@prusnak prusnak deleted the ruff-c branch April 3, 2024 15:56
@prusnak prusnak mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@motorina0 motorina0 motorina0 approved these changes

Assignees

No one assigned

Labels

code health Make the code more beautiful

Projects

None yet

Milestone

0.12.5

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @prusnak @motorina0