Clarified top-up success msg #2381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think the explanation should be in the frontend not the API. i could also be translated there. |
Common misconceptioin is that the top up related to the funds on the funding source. Success msg extended with info that correlated funds on funding source are needed and the amount is virtual until fitting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2381 +/- ##
==========================================
- Coverage 60.79% 60.76% -0.03%
==========================================
Files 65 65
Lines 9336 9337 +1
==========================================
- Hits 5676 5674 -2
- Misses 3660 3663 +3 ☔ View full report in Codecov by Sentry. |
dni
reviewed
Apr 17, 2024
|
Fixed: Note: i18n does not work on |
dni
reviewed
Apr 17, 2024
dni
reviewed
Apr 17, 2024
dni
approved these changes
Apr 17, 2024
dni
reviewed
Apr 17, 2024
arbadacarbaYK
commented
Apr 17, 2024
dni
approved these changes
Apr 17, 2024
motorina0
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common misconceptioin is that the top up is related to the funds on the funding source.
Success msg extended with info that correlated funds on funding source are needed and the amount is virtual until fitting.