test: add tests for alby #2390
Merged
test: add tests for alby #2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2390 +/- ##
==========================================
+ Coverage 59.46% 59.97% +0.50%
==========================================
Files 65 65
Lines 9404 9441 +37
==========================================
+ Hits 5592 5662 +70
+ Misses 3812 3779 -33 ☔ View full report in Codecov by Sentry. |
motorina0
commented
Apr 3, 2024
| return PaymentResponse(False, None, None, None, error_message) | ||
|
|
||
| checking_id = data["payment_hash"] | ||
| # todo: confirm with bitkarrot that having the minus is fine |
There was a problem hiding this comment.
cc: @bitkarrot ☝️
There was a problem hiding this comment.
the fee value returned by Alby is positive.
|
@motorina0 ok gimme a day to check this out. |
dni
approved these changes
Apr 5, 2024
028b01c to
653d6a6
Compare
talvasconcelos
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
albyalby.pyto follow theBaseWalletinterfaceTwo open questions for @bitkarrot:
feevalue negative?keysendpayments ("fee": 1)preimagefor the outgoing payments. I can see in the docs that the generic endpoint (/invoices/{checkin_id}) does not return the pre-image, but the dedicated endpoints do (/invoices/incoming/{checkin_id}, (/invoices/outgoing/{checkin_id})).See the
"skip": truetests for more details.