Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: uninstall un-vetted extenisons #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: uninstall un-vetted extenisons #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lnbits/core/views/extension_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
drop_extension_db,
get_dbversions,
get_installed_extension,
get_installed_extensions,
)

extension_router = APIRouter(
Expand Down Expand Up @@ -123,9 +124,9 @@ async def api_uninstall_extension(
user: User = Depends(check_admin),
access_token: Optional[str] = Depends(check_access_token),
):
installable_extensions = await InstallableExtension.get_installable_extensions()
installed_extensions = await get_installed_extensions()

extensions = [e for e in installable_extensions if e.id == ext_id]
extensions = [e for e in installed_extensions if e.id == ext_id]
if len(extensions) == 0:
raise HTTPException(
status_code=HTTPStatus.BAD_REQUEST,
Expand All @@ -135,7 +136,7 @@ async def api_uninstall_extension(
# check that other extensions do not depend on this one
for valid_ext_id in [ext.code for ext in get_valid_extensions()]:
installed_ext = next(
(ext for ext in installable_extensions if ext.id == valid_ext_id), None
(ext for ext in installed_extensions if ext.id == valid_ext_id), None
)
if installed_ext and ext_id in installed_ext.dependencies:
raise HTTPException(
Expand Down