Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: adhere to ruff's RUF rules, 2nd try #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2024
Merged

chore: adhere to ruff's RUF rules, 2nd try #2420

merged 3 commits into from
Apr 17, 2024

Conversation

@dni
Copy link
Member

@dni dni commented Apr 16, 2024

closes #2382

@dni dni requested review from motorina0 and prusnak and removed request for motorina0 April 16, 2024 08:44
@dni dni added this to the 0.12.6 milestone Apr 16, 2024
@codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 60.75%. Comparing base (d78f6a1) to head (dc17138).

Files Patch % Lines
lnbits/commands.py 0.00% 6 Missing ⚠️
lnbits/app.py 25.00% 3 Missing ⚠️
lnbits/extension_manager.py 0.00% 3 Missing ⚠️
lnbits/tasks.py 0.00% 3 Missing ⚠️
lnbits/core/views/public_api.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2420      +/-   ##
==========================================
+ Coverage   60.55%   60.75%   +0.20%     
==========================================
  Files          65       65              
  Lines        9336     9337       +1     
==========================================
+ Hits         5653     5673      +20     
+ Misses       3683     3664      -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni requested a review from arcbtc April 16, 2024 10:21
motorina0
motorina0 reviewed Apr 16, 2024
View reviewed changes
@dni dni merged commit daa1b5a into dev Apr 17, 2024
@dni dni deleted the ruff-ruf-2 branch April 17, 2024 05:36
@prusnak prusnak mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@motorina0 motorina0 motorina0 approved these changes

@arcbtc arcbtc Awaiting requested review from arcbtc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.12.6

Development

Successfully merging this pull request may close these issues.

3 participants

@dni @prusnak @motorina0