Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dni
Copy link
Member

@dni dni commented Apr 17, 2024

last of the ruff checks.

closes #2308

last of the ruff checks.

closes #2308
@dni dni requested review from motorina0 and prusnak April 17, 2024 06:19
@dni dni marked this pull request as ready for review April 17, 2024 06:19
add cleanup
@dni dni changed the title feat: ahdere to ruff's B rules feat: adhere to ruff's B rules Apr 17, 2024
@dni dni mentioned this pull request Apr 17, 2024
@codecov
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 60.75%. Comparing base (daa1b5a) to head (a36939d).
Report is 1 commits behind head on dev.

Files Patch % Lines
lnbits/core/views/auth_api.py 0.00% 34 Missing ⚠️
lnbits/core/views/extension_api.py 0.00% 14 Missing ⚠️
lnbits/core/views/payment_api.py 36.36% 7 Missing ⚠️
lnbits/nodes/cln.py 56.25% 7 Missing ⚠️
lnbits/core/services.py 16.66% 5 Missing ⚠️
lnbits/core/views/generic.py 0.00% 5 Missing ⚠️
lnbits/extension_manager.py 16.66% 5 Missing ⚠️
lnbits/core/helpers.py 0.00% 4 Missing ⚠️
lnbits/decorators.py 20.00% 4 Missing ⚠️
lnbits/core/views/tinyurl_api.py 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2423      +/-   ##
==========================================
- Coverage   60.76%   60.75%   -0.02%     
==========================================
  Files          65       65              
  Lines        9337     9351      +14     
==========================================
+ Hits         5674     5681       +7     
- Misses       3663     3670       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni requested a review from talvasconcelos April 17, 2024 07:09
@dni dni merged commit 98ec59d into dev Apr 17, 2024
@dni dni deleted the ruff-b branch April 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable more checks for ruff

3 participants