fix: broken lnurl_callback #2445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes withdrawing in lnbits wallet, i broke it removing it with the balance_notify pr, sorry, mybad :( broken jmeter task obscured the issue so they remained undetected by the ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2445 +/- ##
==========================================
- Coverage 60.75% 60.68% -0.08%
==========================================
Files 65 65
Lines 9351 9367 +16
==========================================
+ Hits 5681 5684 +3
- Misses 3670 3683 +13 ☔ View full report in Codecov by Sentry. |
talvasconcelos
approved these changes
Apr 18, 2024
arcbtc
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug introduced by #2293
this fixes withdrawing in lnbits wallet, i broke it removing it with the balance_notify pr, sorry, mybad :( broken jmeter task obscured the issue so they remained undetected by the ci