feat: remove magic argument parser from lnbits command #2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
got the idea from: #2447 arguments it should be explicity allowed with `click` and a description should be added like here: ``` (lnbits-py3.10) dni@arch:~/repos/lnbits/lnbits (dev) $ lnbits --help 130 Usage: lnbits [OPTIONS] Launched with `poetry run lnbits` at root level Options: --port INTEGER Port to listen on --host TEXT Host to run LNBits on --forwarded-allow-ips TEXT Allowed proxy servers --ssl-keyfile TEXT Path to SSL keyfile --ssl-certfile TEXT Path to SSL certificate --help Show this message and exit. ```
a986da1 to
06ee356
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2448 +/- ##
==========================================
+ Coverage 60.69% 60.74% +0.05%
==========================================
Files 65 65
Lines 9367 9360 -7
==========================================
+ Hits 5685 5686 +1
+ Misses 3682 3674 -8 ☔ View full report in Codecov by Sentry. |
prusnak
approved these changes
Apr 19, 2024
motorina0
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got the idea from: #2447
arguments it should be explicity allowed with
clickand a description should be added like here: