feat: add settings.lnbits_running
#2450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings.lnbits_runing settings.lnbits_running
dni
reviewed
Apr 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2450 +/- ##
==========================================
+ Coverage 60.85% 60.87% +0.01%
==========================================
Files 65 65
Lines 9363 9395 +32
==========================================
+ Hits 5698 5719 +21
- Misses 3665 3676 +11 ☔ View full report in Codecov by Sentry. |
|
@dni does it make sense to set this flag also when |
arcbtc
approved these changes
Apr 19, 2024
talvasconcelos
approved these changes
Apr 19, 2024
|
@motorina0 i would set it in |
dni
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2399
There should be no
while Trueloops in the app.Instead
while settings.lnbits_runing:should be used.On the shutdown signal do
settings.lnbits_runing = False.This change also helps while testing. Previous infinite loops can no be stoped.