feat: corelightning maxfee and custom pay command
#2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2464 +/- ##
=======================================
Coverage 61.43% 61.43%
=======================================
Files 65 65
Lines 9430 9430
=======================================
Hits 5793 5793
Misses 3637 3637 ☔ View full report in Codecov by Sentry. |
we should use maxfee instead of calculating the ratio and pass it through. also make it possible to run a custom pay command
motorina0
approved these changes
Apr 25, 2024
talvasconcelos
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should use maxfee instead of calculating the ratio and pass it through.
also make it possible to run a custom pay command