refactor: catch payment and invoice error at fastapi exceptionhandler level #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2484 +/- ##
==========================================
+ Coverage 61.65% 61.75% +0.09%
==========================================
Files 68 69 +1
Lines 9720 9729 +9
==========================================
+ Hits 5993 6008 +15
+ Misses 3727 3721 -6 ☔ View full report in Codecov by Sentry. |
9da23a5 to
f55b1b3
Compare
motorina0
approved these changes
May 10, 2024
466ffac to
5c84fb0
Compare
…evel refactor exceptionhandlers into `exception.py` also now always throw payment error when pay_invoice and invoice errors when create_invoice. return a status flag with the detailed error message. with a 520 response ruff
5c84fb0 to
96bbf45
Compare
talvasconcelos
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor exceptionhandlers into
exception.pyalso now always throw payment error when pay_invoice and invoice errors when create_invoice.return a status flag with the detailed error message. with a 520 response