fix: pay invoice status #2481
Merged
fix: pay invoice status #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2481 +/- ##
==========================================
+ Coverage 61.81% 61.83% +0.01%
==========================================
Files 67 67
Lines 9583 9611 +28
==========================================
+ Hits 5924 5943 +19
- Misses 3659 3668 +9 ☔ View full report in Codecov by Sentry. |
767cecc to
117c93a
Compare
50c949a to
5def2b8
Compare
d09731c to
37defa4
Compare
|
Note: regtest fails for reasons outside this PR. Should be fixed soon. |
6fb7293 to
40f938d
Compare
40f938d to
68dfef7
Compare
dni
approved these changes
May 10, 2024
dni
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue for failed
outgoing payments.If an outgoing payment (invoice paid by the user) is marked as failed, then it will be deleted after a certain time interval.
The (current) reason for deleting the failed outgoing payment is to unlock the user funds. Because while the payment is still present the amount is considered locked.
The issue is that sometimes the
outgoing paymentcan be marked as failed for technical reason, BUT the invoice is not actually canceled.The solution in this PR is to:
failedunless the funding source explicitly returns a status that says the payment is failedpendingget_payment_statusfor all funding sources returnsfailedunder some conditionalbyandpoenixdhave an issue here