Fix: Wrong expiration date in invoice details #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2506 +/- ##
==========================================
+ Coverage 61.73% 61.75% +0.01%
==========================================
Files 69 69
Lines 9696 9689 -7
==========================================
- Hits 5986 5983 -3
+ Misses 3710 3706 -4 ☔ View full report in Codecov by Sentry. |
dni
reviewed
May 16, 2024
dni
added a commit
to lnbits/bolt11
that referenced
this pull request
May 16, 2024
dni
added a commit
to lnbits/bolt11
that referenced
this pull request
May 16, 2024
dni
reviewed
May 16, 2024
dni
approved these changes
May 16, 2024
|
closes #2054 |
arcbtc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2054
The rationale for this change is explained in the issue's discussion: #2054 (comment)
Summary: The Bolt 11 spec says that an invoice, without the
xtag field specified, should expire by default in 1 hour (3600 seconds). Thebolt11package used by lnbits does not implement this, setting theexpirytoNonewhen the tag field is absent. The current implemented fallback sets the expiration date to 1 month after the creation date, which is incompatible with the spec and creates the reported differences between lnbits and other tools that decode the same invoice.