fix: phoenixd wallet description field supports lnurlp #2514
Conversation
|
I did a quick test, with this branch nostr zaps dont work, but with #2513 they work. |
|
Yeah, its unclear to me why the pattern for the lnurlp extension is sending the metadata as description if that needs to be dropped on the floor and use the memo instead. There's likely breakage for lnurlp and nostr zaps across other funding sources for the same reason (opennode,zbd,...) |
|
Thanks @Funman2 for the check on nostr. I hadn't tried that but just put in the tweak needed to make it work by encoding the description field when it needs hashed. |
|
It works now with nostr. |
85ea4a7 to
def7f1d
Compare
|
Rebased to dev, and squashed commits |
5c6e86e to
5395fd1
Compare
|
Resolved what I could of linting issues, but there's still some disparity between len and Sized |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2514 +/- ##
==========================================
+ Coverage 61.79% 62.00% +0.20%
==========================================
Files 69 69
Lines 9703 9737 +34
==========================================
+ Hits 5996 6037 +41
+ Misses 3707 3700 -7 ☔ View full report in Codecov by Sentry. |
Where exactly? I don't see any CI failures now |
To me the nostr native zaps still not working... |
eb41f08 to
44b458e
Compare
- Support description, restricted to 128 characters - Support descriptionHash
|
@dni this one is ready, plz review and merge |
|
tACK |
* Fix for phoenixd and lnurlp nostr usage - Support description, restricted to 128 characters - Support descriptionHash Co-authored-by: Pavol Rusnak <[email protected]> Co-authored-by: Vic <[email protected]>
Similar resolution as #2513, but leaves in comments and applies description.
Tested with lnurlp extension locally with phoenixd 0.1.5-6845a31 in testnet, with assignment of unhashed_description or memo.