Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix] check user extension access #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

[fix] check user extension access #2519

merged 3 commits into from
May 21, 2024

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented May 21, 2024 •
edited
Loading

Summary

It was previously possible for a user to access an installed extension even if the user did not explicitly enabled that extension.
With this PR the enable/disable state for an extension is enforced for both the UI and the API.

Prerequisite for #2516

Test Scenario

@motorina0 motorina0 changed the title [Feat] check user ext access [fix] check user ext access May 21, 2024
@codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 61.80%. Comparing base (35bb3cc) to head (d757ef7).

Files Patch % Lines
lnbits/decorators.py 63.63% 4 Missing ⚠️
lnbits/app.py 0.00% 3 Missing ⚠️
lnbits/core/views/extension_api.py 0.00% 3 Missing ⚠️
lnbits/core/views/generic.py 0.00% 3 Missing ⚠️
lnbits/extension_manager.py 25.00% 3 Missing ⚠️
lnbits/settings.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2519      +/-   ##
==========================================
+ Coverage   61.76%   61.80%   +0.04%     
==========================================
  Files          69       69              
  Lines        9689     9703      +14     
==========================================
+ Hits         5984     5997      +13     
- Misses       3705     3706       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 requested review from arcbtc, dni and prusnak May 21, 2024 08:08
@motorina0 motorina0 marked this pull request as ready for review May 21, 2024 08:09
@motorina0 motorina0 changed the title [fix] check user ext access [fix] check user extension access May 21, 2024
@arcbtc
Copy link
Member

arcbtc commented May 21, 2024

image
Perfect!

@motorina0 motorina0 merged commit 0d447f6 into dev May 21, 2024
@motorina0 motorina0 deleted the feat_check_user_ext_access branch May 21, 2024 10:17
dni pushed a commit that referenced this pull request May 22, 2024
@motorina0 @dni
[fix] check user extension access (#2519)
eb41f08 
* feat: check user extension access
* fix: handle upgraded extensions
dni pushed a commit that referenced this pull request May 22, 2024
@motorina0 @dni
[fix] check user extension access (#2519)
44b458e 
* feat: check user extension access
* fix: handle upgraded extensions
motorina0 added a commit that referenced this pull request Jul 10, 2024
@motorina0
[fix] check user extension access (#2519)
703016f 
* feat: check user extension access
* fix: handle upgraded extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dni dni dni approved these changes

@arcbtc arcbtc arcbtc approved these changes

@prusnak prusnak Awaiting requested review from prusnak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@motorina0 @arcbtc @dni