[feat] Check payment tag #2522
Merged
[feat] Check payment tag #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2522 +/- ##
==========================================
- Coverage 61.80% 61.79% -0.01%
==========================================
Files 69 69
Lines 9703 9717 +14
==========================================
+ Hits 5997 6005 +8
- Misses 3706 3712 +6 ☔ View full report in Codecov by Sentry. |
motorina0
commented
May 21, 2024
| return invoice.payment_hash | ||
|
|
||
|
|
||
| def _check_wallet_balance( |
There was a problem hiding this comment.
this function was extracted because the parent function was getting too large and flake8 complained
dni
approved these changes
May 22, 2024
eb41f08 to
44b458e
Compare
9b03c6d to
c796540
Compare
talvasconcelos
approved these changes
May 24, 2024
motorina0
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: check if the payment is made for an extension that the user disabed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not allow payments from extensions that are disabled by the user.
Steps:
withdrawextensionwithdraw linkand shares itwithdrawextensionActual Result:
withdraw linkstill workingExpected Result:
withdraw linkdoes not work until thewithdrawextension is enabled againNote:
this functionality relies on the fact that extensions use the
"tag"field in the "'extra'" optionsthe function
_check_wallet_balanceis a simple refactor (no business logic changes) it was required by the code check tools (parent function was getting too large)