[fix] editable fields with default=None must be Optional
#2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2530 +/- ##
=======================================
Coverage 61.80% 61.80%
=======================================
Files 69 69
Lines 9703 9703
=======================================
Hits 5997 5997
Misses 3706 3706 ☔ View full report in Codecov by Sentry. |
default=None must be Optional
dni
approved these changes
May 22, 2024
arcbtc
approved these changes
May 22, 2024
motorina0
added a commit
that referenced
this pull request
Jul 10, 2024
* fix: optional fields * fix: bad uppercase field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumary:
Optional. This is is only required for editable fields.LNBITS_SHOW_HOME_PAGE_ELEMENTSProblem:
In the settings, a field of this form is considered optional:
However, if the default value changes then the field is no longer considered optional.
Solution:
Optional fields are declared as
Optional: