Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@motorina0
Copy link
Collaborator

@motorina0 motorina0 commented May 23, 2024

Reported here: #2531

Changes:

  • replace in all SQL queries user = ? with "user"" = ?
  • add try-except for webpush_api enpoints

@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 61.75%. Comparing base (b15596d) to head (67d51b0).

Files Patch % Lines
lnbits/core/views/webpush_api.py 5.55% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2533      +/-   ##
==========================================
- Coverage   61.79%   61.75%   -0.04%     
==========================================
  Files          69       69              
  Lines        9703     9712       +9     
==========================================
+ Hits         5996     5998       +2     
- Misses       3707     3714       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni merged commit ae60b45 into dev May 23, 2024
@dni dni deleted the fix_create_webpush_notification branch May 23, 2024 08:16
motorina0 added a commit that referenced this pull request Jul 10, 2024
* fix: replace all SQL `user = ?` with `"user"" = ?`
* fix: surround with try-catch
* fix: bad double quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants