[feat] Extension details page #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2544 +/- ##
==========================================
+ Coverage 59.30% 61.24% +1.94%
==========================================
Files 69 69
Lines 9875 9914 +39
==========================================
+ Hits 5856 6072 +216
+ Misses 4019 3842 -177 ☔ View full report in Codecov by Sentry. |
0535cd4 to
5846199
Compare
ea2dd63 to
5c64506
Compare
arcbtc
approved these changes
Jun 19, 2024
talvasconcelos
approved these changes
Jun 19, 2024
ram0verflow
pushed a commit
to ram0verflow/lnbits
that referenced
this pull request
Jul 3, 2024
* feat: add empty dialog * feat: add `details_link` field for extension * feat: show info icon if `details_link` present * feat: add extension details endpoint * feat: first details page * feat: carousel working * feat: full screen * fix: layout * fix: repo site * fix: release icon * fix: repo link * feat: terms and conditions partial * chore: fix typing * fix: info icon layout * chore: add try-catch * feat: layout improvements * feat: add video link * fix: show terms and conditions * chore: code format * feat: add `details_link` * fix: github release details * feat: add close button * chore: code clean-up * chore: revert some changes * feat: i18n * chore: `make bundle` * chore: make bundle * feat: terms and conditions is a link now
motorina0
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: add empty dialog * feat: add `details_link` field for extension * feat: show info icon if `details_link` present * feat: add extension details endpoint * feat: first details page * feat: carousel working * feat: full screen * fix: layout * fix: repo site * fix: release icon * fix: repo link * feat: terms and conditions partial * chore: fix typing * fix: info icon layout * chore: add try-catch * feat: layout improvements * feat: add video link * fix: show terms and conditions * chore: code format * feat: add `details_link` * fix: github release details * feat: add close button * chore: code clean-up * chore: revert some changes * feat: i18n * chore: `make bundle` * chore: make bundle * feat: terms and conditions is a link now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test manifest: https://raw.githubusercontent.com/lnbits/lnbits-extensions/details_link/extensions.json
config.jsonpathScreenshot
Details Cues
Details Page
Embedded video
Backwards compatible
