Nice formatting of funding source titles in Server admin #2543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
blackcoffeexbt
commented
Jun 6, 2024
- Update to Server admin to use the human readable funding source name.
- Update to Server admin to sort funding sources alphabetically
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2543 +/- ##
=======================================
Coverage 61.39% 61.39%
=======================================
Files 69 69
Lines 9873 9873
=======================================
Hits 6062 6062
Misses 3811 3811 ☔ View full report in Codecov by Sentry. |
dni
approved these changes
Jun 6, 2024
motorina0
reviewed
Jun 7, 2024
| mixins: [windowMixin], | ||
| props: ['form-data', 'allowed-funding-sources'], | ||
| methods: { | ||
| getFundingSourceLabel(item) { |
There was a problem hiding this comment.
why is this needed?
what was being displayed without it?
There was a problem hiding this comment.
Without this, the [0] value is being displayed e.g. "CoreLightningWallet" this changes the drop down labels to:
CoreLightningWallet > Core Lightning
CoreLightningRestWallet > Core Lightning Rest
LndWallet > Lightning Network Daemon (LND)
etc
motorina0
approved these changes
Jun 8, 2024
motorina0
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Display friendly funding source titles in funding sources list * Sort funding options select alphabetically * Run make bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.