feat: improve on extension page layout #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
give it more luft and simplify it a bit. also improved responsiveness
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2558 +/- ##
==========================================
- Coverage 61.24% 61.00% -0.25%
==========================================
Files 69 69
Lines 9914 9914
==========================================
- Hits 6072 6048 -24
- Misses 3842 3866 +24 ☔ View full report in Codecov by Sentry. |
|
I think its nice to keep the short description once activated, space is not an issue, as most people will only have a dozen or so extensions enabled, and the "new version" badge seems a bit floaty. |
|
I like @dni chnages, looks waaaayyy better on mobile, but I think we should keep the short description |
arcbtc
approved these changes
Jun 26, 2024
ram0verflow
pushed a commit
to ram0verflow/lnbits
that referenced
this pull request
Jul 3, 2024
* feat: improve on extension page layout give it more luft and simplify it a bit. also improved responsiveness * show description now, ben
motorina0
pushed a commit
that referenced
this pull request
Jul 10, 2024
* feat: improve on extension page layout give it more luft and simplify it a bit. also improved responsiveness * show description now, ben
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplified and improved responsiveness