docs: nginx websocket support for reverse proxy #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websocket weren't working with that conf
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2564 +/- ##
==========================================
+ Coverage 61.24% 61.26% +0.02%
==========================================
Files 69 69
Lines 9914 9914
==========================================
+ Hits 6072 6074 +2
+ Misses 3842 3840 -2 ☔ View full report in Codecov by Sentry. |
|
I pushed another commit which cleanups the config change - I have been using it like this for ages and it works. Also the commit adds more directives which are needed for some of the extensions. |
prusnak
approved these changes
Jun 28, 2024
arcbtc
approved these changes
Jul 9, 2024
motorina0
pushed a commit
that referenced
this pull request
Jul 10, 2024
* docs: nginx websocket support for reverse proxy websocket weren't working with that conf * cleanup --------- Co-authored-by: Pavol Rusnak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocket weren't working with that conf