bug: carousel and adv desc fix #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2562 +/- ##
=======================================
Coverage 61.25% 61.25%
=======================================
Files 69 69
Lines 9914 9914
=======================================
Hits 6073 6073
Misses 3841 3841 ☔ View full report in Codecov by Sentry. |
motorina0
approved these changes
Jun 26, 2024
dni
approved these changes
Jun 26, 2024
ram0verflow
pushed a commit
to ram0verflow/lnbits
that referenced
this pull request
Jul 3, 2024
* Carousel image fix * pushed carousel nav to top as well so yt controls are accessible * Added some extra breathing room for the adv description
motorina0
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Carousel image fix * pushed carousel nav to top as well so yt controls are accessible * Added some extra breathing room for the adv description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes carousel and adv desc dialog. Extensions page also had a div in the wrong place
Carousel was stretching images
After fix:
Before:
Adv desc looking heaps better on mobile
video_2024-06-25_21-55-45.mp4