[feat] add default_user_extensions setting
#2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2571 +/- ##
==========================================
+ Coverage 61.23% 61.33% +0.10%
==========================================
Files 69 69
Lines 9921 9924 +3
==========================================
+ Hits 6075 6087 +12
+ Misses 3846 3837 -9 ☔ View full report in Codecov by Sentry. |
motorina0
commented
Jul 9, 2024
| # -------- | ||
|
|
||
|
|
||
| async def create_user( |
There was a problem hiding this comment.
Note: create_user and create_account were overlapping. There is now a function in services called create_user_account which encapsulates the logic from here
dni
reviewed
Jul 9, 2024
dni
approved these changes
Jul 9, 2024
arcbtc
approved these changes
Jul 9, 2024
motorina0
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: add `lnbits_user_default_extensions` to `settings` * refactor: extract `create_user_account` in services * feat: auto enable user extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Have a list of extensions which are pre-enabled for the regular users.
Steps:
Note: existing users will not get these extensions enabled by default.