feat: log with console.error on notifyApiError
#2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2646 +/- ##
==========================================
+ Coverage 57.62% 58.32% +0.70%
==========================================
Files 75 75
Lines 11404 11404
==========================================
+ Hits 6571 6651 +80
+ Misses 4833 4753 -80 ☔ View full report in Codecov by Sentry. |
prusnak
approved these changes
Aug 21, 2024
usually why have code like that
```
getAudit() {
LNbits.api
.request('GET', '/admin/api/v1/audit',
this.g.user.wallets[0].adminkey)
.then(response => {
this.auditData = response.data
xonst myerror = isSwallowed()
})
.catch(function (error) {
LNbits.utils.notifyApiError(error)
})
},
```
which if you make a mistake hides your error. logging console.error here
again makes it easier to see what is happening while developing and
doesnt hurt for the user aswell
607f876 to
696422e
Compare
arcbtc
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usually we have code like that
which if you make a mistake hides your error. logging console.error here again makes it easier to see what is happening while developing and does not hurt for the user aswell.
before:
after:
