fix: phoenixd pending payments #3075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dni
commented
Mar 31, 2025
- if phoenixd return 404 on incoming payments the invoice was either never created or is expired
- if phoenixd return 404 on outgoing they were never created
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3075 +/- ##
==========================================
- Coverage 61.04% 61.01% -0.03%
==========================================
Files 110 110
Lines 14320 14343 +23
==========================================
+ Hits 8741 8752 +11
- Misses 5579 5591 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f14219b to
a323011
Compare
71d56dd to
b91cee0
Compare
|
@motorina0 this would be a useful PR to deal with phoenixd with many pending invoices. Can we reopen the PR? For example, I have an instance with nearly 4000 pending invoices. |
b91cee0 to
451bd19
Compare
451bd19 to
63e23eb
Compare
- if phoenixd return 404 on incoming payments the invoice was either never created or is expired - if phoenixd return 404 on outgoing they were never created
63e23eb to
e081fbd
Compare
motorina0
approved these changes
Jul 4, 2025
dni
added a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Vlad Stan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.