[feat] Add stripe payments #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3184 +/- ##
==========================================
+ Coverage 60.51% 61.02% +0.51%
==========================================
Files 105 111 +6
Lines 13817 14296 +479
==========================================
+ Hits 8361 8724 +363
- Misses 5456 5572 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6056fd4 to
0f73535
Compare
motorina0
commented
Jun 6, 2025
8ee77e6 to
18ed036
Compare
f1f080a to
4e18812
Compare
2882a08 to
d0d1dc5
Compare
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
Comment on lines
78
to
87
| class FiatPaymentSuccessStatus(FiatPaymentStatus): | ||
| paid = True | ||
|
|
||
|
|
||
| class FiatPaymentFailedStatus(FiatPaymentStatus): | ||
| paid = False | ||
|
|
||
|
|
||
| class FiatPaymentPendingStatus(FiatPaymentStatus): | ||
| paid = None |
dni
reviewed
Jun 27, 2025
| class FiatPaymentResponse(NamedTuple): | ||
| # when ok is None it means we don't know if this succeeded | ||
| ok: bool | None = None | ||
| checking_id: str | None = None # payment_hash, rcp_id |
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
dni
reviewed
Jun 27, 2025
Comment on lines
+730
to
+731
| from lnbits.tasks import create_task | ||
|
|
There was a problem hiding this comment.
# tasks.py
from lnbits.core.services.payments import handle_fiat_payment_confirmation`because now tasks.py imports from services (which is fine) and there is a circular dependecy
dni
reviewed
Jun 27, 2025
| raise ValueError( | ||
| f"The amount exceeds the '{fiat_provider_name}'" | ||
| "faucet wallet balance.", | ||
| ) |
There was a problem hiding this comment.
howe about creating a services/fiat_payments.py we already at 1k lines
There was a problem hiding this comment.
the fiat payment logic is coupled with the regular payment logic (created payments, etc)
dni
reviewed
Jun 27, 2025
| def is_internal(self) -> bool: | ||
| return self.checking_id.startswith("internal_") | ||
| return self.checking_id.startswith("internal_") or self.checking_id.startswith( | ||
| "fiat_" |
There was a problem hiding this comment.
why does is_internal also check if its fiat?
There was a problem hiding this comment.
fiat payments are always internal payments, but I wanted to have an explicit prefix for it
dni
reviewed
Jun 27, 2025
2617c5f to
9a0899e
Compare
arcbtc
approved these changes
Jun 30, 2025
talvasconcelos
approved these changes
Jun 30, 2025
dni
pushed a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow stripe payments
This PR allows the admin to configure
stripeas a fiat payment provider.This feature allows all (or a selected subset) of users to RECEIVE payments via stripe.
lnbits_stripe.mp4
User Flow
When the Fiat Provider is configured (
Stripein this case) the end user is allowed to select how it wants to receive the funds (lightning or stripe):If the user selects
Stripethen a Stripe Payment Request is generated instead of a LN bolt11.The buyer/payer can scan the QR code or click on it and it will be redirected to a Stripe checkout page like this one:
After the Stripe payment is completed, Stripe will send a notification to the LNbits instance and the LNbits payment will be marked as successful.
For a user that only has fiat funds, but wants to PAY a bolt11 Lightning Invoice (received from someone) then all it has to do is:
Admin Configs
Admins now have a
Fiat Providerstab where they can configure multiple fiat providers (for now only Stripe is supported):These configs should be self explanatory (they have hints and descriptions).
Todos: