Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@talvasconcelos
Copy link
Collaborator

@talvasconcelos talvasconcelos commented Jun 24, 2025

Handle server errors and be more informative. I think 5 sec is more than enough as timeout. Should we change it?

Fixes #3188

@talvasconcelos talvasconcelos requested review from dni and motorina0 June 24, 2025 14:28
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (6d2f39d) to head (91168a5).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
lnbits/core/views/api.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3214      +/-   ##
==========================================
- Coverage   60.36%   60.34%   -0.02%     
==========================================
  Files         105      105              
  Lines       13684    13687       +3     
==========================================
  Hits         8260     8260              
- Misses       5424     5427       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@motorina0 motorina0 merged commit 7c0a955 into dev Jun 24, 2025
43 checks passed
@motorina0 motorina0 deleted the fix_lnurlscan_error_handling branch June 24, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] response is undefined when lnurlscan times out

3 participants