feat: run_interval in tasks and refactor check_pending_payments
#3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorina0
reviewed
Jul 7, 2025
| await asyncio.sleep(sleep_time) | ||
| async def wrapper() -> None: | ||
| while settings.lnbits_running: | ||
| await func() |
There was a problem hiding this comment.
this should be in a try-catch so the loop does not stop in case of exception
There was a problem hiding this comment.
this is already done by create_permanent_task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3245 +/- ##
==========================================
+ Coverage 60.26% 60.27% +0.01%
==========================================
Files 111 111
Lines 14583 14585 +2
==========================================
+ Hits 8788 8791 +3
+ Misses 5795 5794 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
motorina0
approved these changes
Jul 7, 2025
dni
added a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.