[fix] bandit assert warnings #3243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3243 +/- ##
==========================================
- Coverage 60.45% 60.27% -0.19%
==========================================
Files 111 111
Lines 14529 14583 +54
==========================================
+ Hits 8784 8790 +6
- Misses 5745 5793 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
804b91b to
5c5814d
Compare
dni
approved these changes
Jul 5, 2025
dni
added a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: dni ⚡ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Python’s assert statement is meant for debugging, not production security checks. The issue is that:
- When Python runs in optimized mode (with
-Oor-OO), all assert statements are stripped out at compile time.- That means any logic relying on assert will not run in production if the interpreter is optimized — potentially skipping critical checks.
Depends on: #3242