Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: reorder .env for a common block for .env only settings #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

chore: reorder .env for a common block for .env only settings #3350

merged 1 commit into from
Sep 17, 2025

Conversation

@hkarani
Copy link
Contributor

@hkarani hkarani commented Sep 4, 2025

No description provided.

@motorina0 motorina0 force-pushed the common-block-for-env-only-secrets branch from f25bdfe to caf8407 Compare September 4, 2025 10:50
@codecov
Copy link

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.17%. Comparing base (c054e47) to head (26d9e70).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3350      +/-   ##
==========================================
- Coverage   57.19%   57.17%   -0.02%     
==========================================
  Files         113      113              
  Lines       14451    14451              
==========================================
- Hits         8265     8263       -2     
- Misses       6186     6188       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@motorina0
Copy link
Collaborator

@hkarani can you please also add lnbits_admin_ui (it is part of ReadOnlySettings)

other than that it LGTM

@hkarani
Copy link
Contributor Author

hkarani commented Sep 10, 2025

On it👍

@motorina0
Copy link
Collaborator

Still open

@hkarani hkarani force-pushed the common-block-for-env-only-secrets branch from caf8407 to 566bc96 Compare September 13, 2025 12:16
@arcbtc arcbtc force-pushed the common-block-for-env-only-secrets branch from 566bc96 to 26d9e70 Compare September 15, 2025 00:17
@arcbtc arcbtc merged commit c05122e into lnbits:dev Sep 17, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arcbtc arcbtc arcbtc approved these changes

@motorina0 motorina0 Awaiting requested review from motorina0

@dni dni Awaiting requested review from dni

@blackcoffeexbt blackcoffeexbt Awaiting requested review from blackcoffeexbt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hkarani @motorina0 @arcbtc