feat: add configurable threshold for balance delta notification #3433
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts#3432) Replaces boolean toggle with numeric threshold input, allowing users to set a minimum change amount (in sats) before receiving balance delta notifications. - Add notification_balance_delta_threshold_sats setting (default: 1 sat) - Update check_balance_delta_changed() to use threshold comparison - Replace toggle with numeric input in admin UI - Update translations to reflect threshold behavior - Fix typo: "diference" → "difference" Benefits: - Routing node operators can filter out small balance changes - Setting to 0 disables notifications - Default of 1 maintains backward compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3433 +/- ##
==========================================
+ Coverage 55.81% 55.83% +0.01%
==========================================
Files 116 116
Lines 15304 15305 +1
==========================================
+ Hits 8542 8545 +3
+ Misses 6762 6760 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3432 - Adds a configurable threshold (in sats) for the "Balance Delta Changed" notification, so it only alerts when the balance delta changes by more than the specified amount.
Changes
notification_balance_delta_changedwith integernotification_balance_delta_threshold_satssetting (default: 1)check_balance_delta_changed()to check if delta change is >= threshold using absolute valueBenefits
Testing
make format)npm run bundle)Screenshots
The Balance Delta notification now has a numeric input instead of a toggle, allowing users to specify the minimum change threshold in sats.
Notes
This is a draft PR pending manual testing with notifications configured. The implementation is complete and all automated checks pass.
🤖 Generated with Claude Code