Hi @rabidaudio
Thanks for your PR!

I appreciate your contribution and your ideas in general about improving Rotating File Endpoints.

I want to look at this further. To that end, I have created a new branch and merged your changes into it.
https://github.com/logkit/logkit/tree/manual-rotating-endpoint

In specific I'd like to give some thought as to whether these changes can be merged into the standard LXRotatingFileEndpoint instead of creating a separate class. They are so close to each other.

And from a broader perspective, I've been thinking about whether there is a better way to structure the File Endpoint family in general. There are some things I'm not happy with.

I'm going to leave this open for now, in case you have further thoughts, which I welcome.

Hi @rabidaudio,

Yesterday I integrated your PR into LogKit's master branch, with a few changes. After your updates to LXRotatingFileEndpoint's structure, it was pretty straightforward to merge LXManuallyRotatingFileEndpoint into it. Here's what changed:

• LXRotatingFileEndpoint now accepts nil as a max file size. If nil is supplied, the Endpoint will never rotate automatically -- only when manually triggered.
• I did not include the Notification that triggers a rotation, and instead just included the public rotate() method. It seemed too weak an association for an Endpoint instance to listen for any "please rotate now" notification, instead of a message aimed specifically at that instance. What if a dev had two different rotating Endpoints in their configuration? It seems safer to use a specific instance's rotate() method (if less convenient -- see below).

I welcome further thoughts on these changes.

However, not all is lost if one is tied to the "please rotate now" notification flow. It would be very easy to subclass the LXRotatingFileEndpoint and get that back with very little code. Something like:

let LXFileEndpointRequestRotationNotification: String = "info.logkit.endpoint.fileEndpoint.requestRotation"

class NoteRotatingFileEndpoint: LXRotatingFileEndpoint {

    deinit { NSNotificationCenter.defaultCenter().removeObserver(self) }

    convenience init?(numberOfFiles: UInt = 5, minimumPriorityLevel: LXPriorityLevel = .All, dateFormatter: LXDateFormatter = LXDateFormatter.standardFormatter(), entryFormatter: LXEntryFormatter = LXEntryFormatter.standardFormatter(), listenForNoteFrom sender: AnyObject? = nil) {
        self.init(numberOfFiles: numberOfFiles, maxFileSizeKiB: nil, minimumPriorityLevel: minimumPriorityLevel, dateFormatter: dateFormatter, entryFormatter: entryFormatter)
        NSNotificationCenter.defaultCenter().addObserverForName(LXFileEndpointRequestRotationNotification, object: sender, queue: nil, usingBlock: { [unowned self] _ in self.rotate() })
    }
}

Sounds good. Your thoughts on the rotate notification make a lot of sense. Thanks!