Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rabidaudio
Copy link
Contributor

Closes #16

Important note for documentation:

The flag needs to be set in LogKit's build settings, not your own project. In hindsight this is obvious, but it messed me up at first.

@rabidaudio
Copy link
Contributor Author

screen shot 2016-03-24 at 3 07 20 pm

@justinpawela
Copy link
Contributor

@rabidaudio Thanks for submitting this PR. I merged your updates in with a little change: I made the advertising ID disabled by default, and did so by making the flag a "disabled" flag. I did this for two reasons:

  • I wanted to prevent future situations like yours, where a developer who is not interested in the advertising ID has to dive into the IDFA docs to understand what Apple is asking and what to do about it. If a developer wants the ID they can remove the flag instead, which will be a documented process.
  • It's easier for a developer that wants to remove the "disabled" flag to find and remove it than it would be for a dev to try to figure out where to put a new flag. Again, this is to prevent situations like yours in the future where a dev has to hunt around to find the right place. As an added benefit, having the "disabled" flag there by default means a dev can just search for it in the build settings page, making it easier to find and remove.

Anyway, thanks again for bringing this up, as it had obviously not affected my situation at all.

@rabidaudio
Copy link
Contributor Author

Great, that makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants